yyj8 commented on PR #18116: URL: https://github.com/apache/pulsar/pull/18116#issuecomment-1307317120
> > I also tend to use new metrics names, like this `pulsar_broker_rate_in`. In other words, you can discuss with [@codelipenghui](https://github.com/codelipenghui) and [michaeljmarshall](https://github.com/michaeljmarshall) which solution we will use is a better choice. > > Sorry, I didn't mean to imply that we shouldn't add a new metric. My question was whether we needed to modify the existing metrics. I see now that the issue is related to working around how Pulsar and Prometheus integrate, and adding a new metric is a short term solution. I support adding a new metric in this case, but I think we should avoid making it a trend. I will change back to the metrics name used in the previous version, like this `pulsar_broker_rate_in`. Thank you very much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
