tisonkun commented on code in PR #18373: URL: https://github.com/apache/pulsar/pull/18373#discussion_r1018170334
########## README.md: ########## @@ -137,8 +137,10 @@ components in the Pulsar ecosystem, including connectors, adapters, and other la - Maven 3.6.1+ - zip -> Note: this project includes a [Maven Wrapper](https://maven.apache.org/wrapper/) that can be used instead of a system installed Maven. -> Use it by replacing `mvn` by `./mvnw` on Linux and `mvnw.cmd` on Windows in the commands below. +> **Note**: +> * This project includes a [Maven Wrapper](https://maven.apache.org/wrapper/) that can be used instead of a system installed Maven. +> Use it by replacing `mvn` by `./mvnw` on Linux and `mvnw.cmd` on Windows in the commands below. +> * It's better to use CMD rather than Powershell on Windows, since maven will activate windows profile and run `rename-netty-native-libs.cmd`. Review Comment: ```suggestion > > This project includes a [Maven Wrapper](https://maven.apache.org/wrapper/) that can be used instead of a system-installed Maven. > Use it by replacing `mvn` by `./mvnw` on Linux and `mvnw.cmd` on Windows in the commands below. > > It's better to use CMD rather than Powershell on Windows. Because maven will activate the `windows` profile which runs `rename-netty-native-libs.cmd`. ``` Improve statement and format. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
