tisonkun commented on code in PR #18363:
URL: https://github.com/apache/pulsar/pull/18363#discussion_r1018689504


##########
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnection.java:
##########
@@ -209,7 +209,7 @@ public synchronized void 
channelInactive(ChannelHandlerContext ctx) throws Excep
     @Override
     public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) 
throws Exception {
         super.exceptionCaught(ctx, cause);
-        LOG.warn("[{}] Got exception {} : Message: {} State: {}", 
remoteAddress, cause.getClass().getSimpleName(),
+        LOG.warn("[{}] Got exception {} : Message: {} State: {} Cause: {}", 
remoteAddress, cause.getClass().getSimpleName(),
                 cause.getMessage(), state,
                 ClientCnx.isKnownException(cause) ? null : cause);

Review Comment:
   Or:
   
   ```java
           LOG.warn("[{}] Got exception {} : Message: {} State: {}",
                   remoteAddress, cause.getClass().getSimpleName(), 
cause.getMessage(), state,
                   ClientCnx.filterKnownException(cause));
   
   // in ClientCnx.java
   
       public static Throwable filterKnownException(Throwable t) {
           return isKnownException(t) ? null : t;
       }
   ```
   
   It's somehow IDEA shortcoming.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to