BewareMyPower commented on PR #105: URL: https://github.com/apache/pulsar-client-cpp/pull/105#issuecomment-1310232501
@merlimat @RobertIndie @Demogorgon314 PTAL. Though I opened a discussion [here](https://lists.apache.org/thread/rdkqnkohbmkjjs61hvoqplhhngr0b0sd) and reached a concensus that Java's MessageId is an opaque, the MessageId in C++ is still constructable from application side. This PR mainly changes the construction from ```c++ // partition: 1, ledger: 2, entry: 3, batch index: 4 MessageId id(1, 2, 3, 4); ``` to ```c++ auto id = MessageIdBuilder().ledgerId(2).entryId(3).partition(1).batchIndex(4).build(); ``` And support `batch_size` field. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
