wolfstudy commented on a change in pull request #12: package logrus for project
URL: https://github.com/apache/pulsar-client-go/pull/12#discussion_r284961399
##########
File path: pulsar/impl_partition_producer.go
##########
@@ -134,7 +131,7 @@ func (p *partitionProducer) grabCnx() error {
})
if err != nil {
- p.log.WithError(err).Error("Failed to create producer")
+ log.Errorf("create producer [%s] error: %+v", *p.producerName,
err)
Review comment:
Yes, the context information is the meaning of the log output. Users can
quickly locate the problem based on this information. Here, I did not remove
the context information, but changed the way to output.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
