nicoloboschi commented on code in PR #18411:
URL: https://github.com/apache/pulsar/pull/18411#discussion_r1019232172


##########
.github/workflows/pulsar-ci.yaml:
##########
@@ -953,11 +954,11 @@ jobs:
   # It cleans up the binaries in the same job in order to not spin up another 
runner for basically doing nothing.
   pulsar-ci-checks-completed:
     name: "Pulsar CI checks completed"
-    if: always()
+    if: ${{ !cancelled() }}

Review Comment:
   I'm not sure. If I cancel the workflow manually then this job is marked as 
skipped and then GH allows me merge the pull. Could you verify it ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to