[GitHub] [pulsar] eolivelli commented on a diff in pull request #18245: InflightReadsLimiter - limit the memory used by reads end-to-end (from storage/cache to the write to the consumer channel)

Fri, 11 Nov 2022 02:38:28 -0800 


eolivelli commented on code in PR #18245:
URL: https://github.com/apache/pulsar/pull/18245#discussion_r1020098104


##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/EntryImpl.java:
##########
@@ -44,6 +44,8 @@ protected EntryImpl newObject(Handle<EntryImpl> handle) {
     private long entryId;
     ByteBuf data;
 
+    private Runnable onDeallocate;

Review Comment:
   this is the pattern we use for every recyclable object, the same comment may 
apply to all the other fields.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to