poorbarcode commented on code in PR #18315:
URL: https://github.com/apache/pulsar/pull/18315#discussion_r1021008841
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentStickyKeyDispatcherMultipleConsumers.java:
##########
@@ -322,15 +322,9 @@ protected synchronized boolean
trySendMessagesToConsumers(ReadType readType, Lis
}
// readMoreEntries should run regardless whether or not stuck is
caused by
// stuckConsumers for avoid stopping dispatch.
- sendInProgress = false;
topic.getBrokerService().executor().execute(safeRun(this::readMoreEntries));
Review Comment:
Should we remove this tow line(line-325, line-327) and make this method
return `true` at these two logic branch? Then `readMoreEntries` will be
triggered by `super.readEntriesComplete`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
