momo-jun commented on code in PR #18509: URL: https://github.com/apache/pulsar/pull/18509#discussion_r1024656007
########## README.md: ########## @@ -191,21 +192,18 @@ Check https://pulsar.apache.org for documentation and examples. ## Build custom docker images -Docker images must be built with Java 8 for `branch-2.7` or previous branches because of -[issue 8445](https://github.com/apache/pulsar/issues/8445). -Java 11 is the recommended JDK version in `branch-2.8`, `branch-2.9` and `branch-2.10`. -Java 17 is the recommended JDK version in `master`. +* Docker images must be built with Java 8 for `branch-2.7` or previous branches because of [ISSUE-8445](https://github.com/apache/pulsar/issues/8445). +* Java 11 is the recommended JDK version in `branch-2.8`, `branch-2.9` and `branch-2.10`. +* Java 17 is the recommended JDK version in `master`. -This builds the docker images `apachepulsar/pulsar-all:latest` and `apachepulsar/pulsar:latest`. +The following command builds the docker images `apachepulsar/pulsar-all:latest` and `apachepulsar/pulsar:latest`: ```bash mvn clean install -DskipTests mvn package -Pdocker,-main -am -pl docker/pulsar-all -DskipTests ``` -After the images are built, they can be tagged and pushed to your custom repository. -Here's an example of a bash script that tags the docker images with the current version and git revision and -pushes them to `localhost:32000/apachepulsar`. +After the images are built, they can be tagged and pushed to your custom repository. Here's an example of a bash script that tags the docker images with the current version and git revision and pushes them to `localhost:32000/apachepulsar`. Review Comment: ```suggestion After the images are built, they can be tagged and pushed to your custom repository. Here's an example of a bash script that tags the docker images with the current version and git revision and pushes them to `localhost:32000/apachepulsar`. ``` ########## CONTRIBUTING.md: ########## @@ -21,6 +21,4 @@ ## Contributing to Apache Pulsar -We would love for you to contribute to Apache Pulsar and make it even better! -Please check the [Contributing to Apache Pulsar](https://pulsar.apache.org/contributing/) -page before starting to work on the project. +We would love for you to contribute to Apache Pulsar and make it even better! Please check the [Apache Pulsar Contributing Guide](https://pulsar.apache.org/contribute/) page before starting to work on the project. Review Comment: ```suggestion We would love for you to contribute to Apache Pulsar and make it even better! Please check the [Apache Pulsar Contributing Guide](https://pulsar.apache.org/contribute/) before starting to work on the project. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
