tisonkun commented on code in PR #18521:
URL: https://github.com/apache/pulsar/pull/18521#discussion_r1025310051
##########
pulsar-client-admin/pom.xml:
##########
@@ -107,6 +107,12 @@
<artifactId>pulsar-package-core</artifactId>
<version>${project.version}</version>
</dependency>
+
+ <dependency>
+ <groupId>org.hamcrest</groupId>
+ <artifactId>hamcrest</artifactId>
+ <scope>test</scope>
+ </dependency>
Review Comment:
Interesting. Why do we need this dependency explicitly now?
##########
pom.xml:
##########
@@ -241,7 +241,7 @@ flexible messaging model and an intuitive client
API.</description>
<!-- Set docker-java.version to the version of docker-java used in
Testcontainers -->
<docker-java.version>3.2.13</docker-java.version>
<kerby.version>1.1.1</kerby.version>
- <testng.version>7.3.0</testng.version>
+ <testng.version>7.5</testng.version>
Review Comment:
I learn the latest version is 7.6.1. Why do we use 7.5 here? Also, 7.5 is
not of a full semantic version format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
