congbobo184 commented on code in PR #18491:
URL: https://github.com/apache/pulsar/pull/18491#discussion_r1025400068
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java:
##########
@@ -712,8 +712,8 @@ public void redeliverUnacknowledgedMessages() {
});
clearIncomingMessages();
unAckedMessageTracker.clear();
+ resumeReceivingFromPausedConsumersIfNeeded();
Review Comment:
https://github.com/apache/pulsar/blob/dd8bd05ad98fa302d5dc85642ef994c20890e171/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java#L691-L692
the core issue is: change the lock to `internalPinnedExecutor` then
`CONSUMER_EPOCH.incrementAndGet(this)`, the epoch can't work, right?
I'm not sure about the PR https://github.com/apache/pulsar/pull/18475, why
do we also need to revert? Is the truth the deadlock?
the fix in https://github.com/apache/pulsar/pull/18454 i am not sure this
fix isn't right.
@codelipenghui @poorbarcode @BewareMyPower @Technoboy- @mattisonchao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
