pgier commented on PR #18451:
URL: https://github.com/apache/pulsar/pull/18451#issuecomment-1318880495
@michaeljmarshall @eolivelli I've removed the changes to the metric type and
only left in the changes to fix the metric value. However, I rebased on the
latest master, and some recent PR seems to have broken a lot of the tests
around prometheus metrics. There are some new metrics introduced that look
like this:
```
pulsar_out_bytes_total: Metric{tags={cluster=test,
namespace=my-property/use/my-ns, subscription=__compaction,
topic=persistent://my-property/use/my-ns/__transaction_buffer_snapshot},
value=0.0}
```
And this breaks the count checks in several unit tests. I'm not sure which
change introduced this issue, but possibly this one:
https://github.com/apache/pulsar/pull/17905
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
