pgier opened a new pull request, #18524: URL: https://github.com/apache/pulsar/pull/18524
This reverts commit 3715934d6046560669e876a94d3cdd580a21c5fa. This change broke several unit tests around metrics. It should be reverted until the associated tests are fixed. Signed-off-by: Paul Gier <[email protected]> ### Motivation Prometheus metrics unit tests are currently broken due to #17905. This temporarily reverts those changes until the tests are fixed. ### Modifications git revert 3715934d6046560669e876a94d3cdd580a21c5fa ### Verifying this change - [ X ] Make sure that the change passes the CI checks. This change is already covered by existing tests. ### Does this pull request potentially affect one of the following parts: *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] Anything that affects deployment ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [ X ] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> ### Matching PR in forked repository PR in forked repository: <!-- ENTER URL HERE --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
