BewareMyPower commented on code in PR #18084: URL: https://github.com/apache/pulsar/pull/18084#discussion_r1025515576
########## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/filter/BrokerFilter.java: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.broker.loadbalance.extensions.filter; + +import java.util.List; +import org.apache.pulsar.broker.loadbalance.BrokerFilterException; +import org.apache.pulsar.broker.loadbalance.extensions.LoadManagerContext; + +/** + * Filter out unqualified Brokers, which are not entered into LoadBalancer for decision-making. + */ +public interface BrokerFilter { + + /** + * The broker filter name. + */ + String name(); + + /** + * Filter out unqualified brokers based on implementation. + * + * @param brokers The full brokers. + * @param context The load manager context. + */ + void filter(List<String> brokers, LoadManagerContext context) throws BrokerFilterException; Review Comment: Though I see the API of `BrokerFilter` under `org.apache.pulsar.broker.loadbalance` package also returns void. But returning void looks not intuitive for a "filter". I prefer returning a `List<String>` no matter if a new list or the `brokers` is returned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
