imaffe opened a new issue, #18532:
URL: https://github.com/apache/pulsar/issues/18532

   ### Search before asking
   
   - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) 
and found nothing similar.
   
   
   ### Motivation
   
   Currently the `JavaInstanceStarter` uses `JCommander` to parse command line 
args. However in certain cases reading from command line is not very flexible 
(think we need to use a env var as an argument but the container has no shell 
access). Thus we need to support reading configs from a file. 
   
   This is necessary for :
   - https://github.com/streamnative/function-mesh/issues/368 
   - https://github.com/streamnative/function-mesh/issues/448
   
   BTW, we can provide a new issue for python as well. 
   
   
   ### Solution
   
   Solution:
   
   - add a new command line flag "--config_file" and accepts a file URl
   - read the file using `PulsarConfigurationLoader` and create a new class` 
JavaInstanceConfiguration extends PulsarConfiguration`. 
   - Config priority : command line >  conf file.
   - Create a new validation class the make sure required field are either 
provided in the file or via command line interface (this means we need to make 
all JCommander required field non-required)
   
   We need to make sure this new feature would not break any existing code.
   
   ### Alternatives
   
   _No response_
   
   ### Anything else?
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [X] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to