congbobo184 commented on code in PR #18486:
URL: https://github.com/apache/pulsar/pull/18486#discussion_r1026415984
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/api/ConsumerRedeliveryTest.java:
##########
@@ -65,6 +68,19 @@ public Object[][] ackReceiptEnabled() {
return new Object[][] { { true }, { false } };
}
+ @DataProvider(name = "batchedMessageAck")
+ public Object[][] batchedMessageAck() {
+ // When batch index ack is disabled (by default), only after all
single messages were sent would the pending
+ // ACK be added into the ACK tracker.
+ return new Object[][] {
+ // numAcked, batchSize, ack type
+ { 3, 5, CommandAck.AckType.Individual },
+ { 5, 5, CommandAck.AckType.Individual },
+ { 3, 5, CommandAck.AckType.Cumulative },
+ { 5, 5, CommandAck.AckType.Cumulative }
Review Comment:
5, 5 test case may not stable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
