shibd commented on code in PR #249:
URL:
https://github.com/apache/pulsar-client-node/pull/249#discussion_r1032167309
##########
.github/workflows/ci-build-release-napi.yml:
##########
@@ -41,13 +41,16 @@ jobs:
- name: Build CPP dependencies lib
if: steps.cache-dependencies.outputs.cache-hit != 'true'
run: |
- export ARCH=${{ matrix.arch }}
+ if [ "${{ matrix.arch }}" = "x64" ]; then
+ export ARCH=x86_64
+ else
+ export ARCH=${{ matrix.arch }}
+ fi
Review Comment:
Because in `build-cpp-deps-lib.sh`, we use `x86_64` parameters uniformly.
Used for configuration `CFLAGS` or `CXXFLAGS`
https://github.com/apache/pulsar-client-node/blob/10ef71a0d235955d91bf763d12513eca51948df0/pkg/mac/build-cpp-deps-lib.sh#L150-L151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
