erobot opened a new pull request, #127:
URL: https://github.com/apache/pulsar-client-cpp/pull/127
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see
*[Guideline - Pulsar PR Naming
Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and
this checklist, leaving only the filled out template below.
-->
### Motivation
<!-- Explain here the context, and why you're making that change. What is
the problem you're trying to solve. -->
Namspace name with underscore is valid before but now invalid. This
regression caused by #52.
Broker validates NamedEntity using regex `"^[-=:.\\w]*$"`, which actually
includes the underscore. Although the comment saying `alphanumeric (a-za-z_0-9)
and these special characters -=:` is a bit confusing. But we should not break
the actual validation rules used a long time ago.
https://github.com/apache/pulsar/blob/355ba6002fc33b2716f59ca5d3a4fac667ecf3e1/pulsar-common/src/main/java/org/apache/pulsar/common/naming/NamedEntity.java#L30-L33
### Modifications
<!-- Describe the modifications you've done. -->
Make underscore valid in NamedEntity.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
This change can covered by existing tests with some modifications, such as
NamespaceNameTest.testNamespaceNameLegalCharacters and
TopicNameTest.testLegalNonAlphaCharacters.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
fix regression only
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
