tisonkun commented on code in PR #18635:
URL: https://github.com/apache/pulsar/pull/18635#discussion_r1032717618
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/v3/AdminApiTransactionTest.java:
##########
@@ -624,8 +624,9 @@ public void testUpdateTransactionCoordinatorNumber() throws
Exception {
}
admin.transactions().scaleTransactionCoordinators(coordinatorSize * 2);
- pulsarClient =
PulsarClient.builder().serviceUrl(lookupUrl.toString()).enableTransaction(true).build();
+
replacePulsarClient(PulsarClient.builder().serviceUrl(lookupUrl.toString()).enableTransaction(true));
pulsarClient.close();
Review Comment:
I'm thinking of using a local PulsarClient instance to trigger the
side-effect instead of replacing since the logical purpose has nothing to do
wth "replace". But you're the author so you make the call of style :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
