BewareMyPower commented on code in PR #250:
URL:
https://github.com/apache/pulsar-client-node/pull/250#discussion_r1032901630
##########
dependencies.yaml:
##########
@@ -24,5 +24,5 @@ protobuf: 3.20.0
zlib: 1.2.13
zstd: 1.5.2
snappy: 1.1.9
-openssl: 1.1.1q
+openssl: 1.1.1s
Review Comment:
Why did you upgrade the OpenSSL version? It's okay to add a patch to an
existing OpenSSL release like the line removed in this PR.
```bash
echo -e "#include <string.h>\n$(cat test/v3ext.c)" > test/v3ext.c
```
It's better to use a separate PR to upgrade the dependency version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
