heesung-sn commented on code in PR #18195:
URL: https://github.com/apache/pulsar/pull/18195#discussion_r1033143208
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/TableViewConfigurationData.java:
##########
@@ -29,13 +29,15 @@ public class TableViewConfigurationData implements
Serializable, Cloneable {
private String topicName = null;
private long autoUpdatePartitionsSeconds = 60;
+ private String topicCompactionStrategy;
Review Comment:
> And why not use TopicCompactionStrategy topicCompactionStrategy directly?
If we don't want to expose it as a public API, we can just ignore the
serialization of the topicCompactionStrategy
I couldn't find a strong benefit to pass 'TopicCompactionStrategy' obj in
this config.
I thought this config needs to be light-weight 'configs' instead of passing
heavy objects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
