lhotari commented on code in PR #31:
URL:
https://github.com/apache/pulsar-client-reactive/pull/31#discussion_r1033307090
##########
pulsar-client-reactive-api/src/main/java/org/apache/pulsar/reactive/client/api/ReactiveMessageReaderBuilder.java:
##########
@@ -17,82 +17,236 @@
package org.apache.pulsar.reactive.client.api;
import java.util.List;
+import java.util.concurrent.TimeUnit;
import org.apache.pulsar.client.api.ConsumerCryptoFailureAction;
import org.apache.pulsar.client.api.CryptoKeyReader;
+import org.apache.pulsar.client.api.MessageId;
+import org.apache.pulsar.client.api.PulsarClientException;
import org.apache.pulsar.client.api.Range;
+import org.apache.pulsar.client.api.Reader;
+import org.apache.pulsar.client.api.ReaderBuilder;
+/**
+ * Builder interface for {@link ReactiveMessageReader}.
+ *
+ * @param <T> the message payload type
+ * @author Lari Hotari
+ * @author Christophe Bornet
+ */
public interface ReactiveMessageReaderBuilder<T> {
+ /**
+ * Sets the position where to start reading from.
+ * <p>
+ * This setting applies to each new {@link Reader} created under the
built
+ * {@link ReactiveMessageReader}.
+ * @param startAtSpec the position where to start reading from
+ * @return the reader builder instance
+ * @see ReaderBuilder#startMessageId(MessageId)
+ * @see ReaderBuilder#startMessageIdInclusive()
+ * @see ReaderBuilder#startMessageFromRollbackDuration(long, TimeUnit)
+ */
ReactiveMessageReaderBuilder<T> startAtSpec(StartAtSpec startAtSpec);
+ /**
+ * Sets the action to perform once the end of the stream is reached.
+ * @param endOfStreamAction the action to perform once the end of the
stream is
+ * reached
Review Comment:
Proper docs for endOfStreamAction will be covered in #40.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
