This is an automated email from the ASF dual-hosted git repository.
lhotari pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pulsar-client-reactive.git
The following commit(s) were added to refs/heads/main by this push:
new f635ed5 Move toImmutableSpec implementation to interfaces (#33)
f635ed5 is described below
commit f635ed5726261c28ab4202ac324c5b7c465a0f63
Author: Christophe Bornet <[email protected]>
AuthorDate: Mon Nov 28 10:44:58 2022 +0100
Move toImmutableSpec implementation to interfaces (#33)
Co-authored-by: Lari Hotari <[email protected]>
---
.../internal/adapter/AdaptedReactiveMessageConsumerBuilder.java | 7 -------
.../internal/adapter/AdaptedReactiveMessageReaderBuilder.java | 7 -------
.../internal/adapter/AdaptedReactiveMessageSenderBuilder.java | 7 -------
.../pulsar/reactive/client/api/ReactiveMessageConsumerBuilder.java | 4 +++-
.../pulsar/reactive/client/api/ReactiveMessageReaderBuilder.java | 4 +++-
.../pulsar/reactive/client/api/ReactiveMessageSenderBuilder.java | 4 +++-
6 files changed, 9 insertions(+), 24 deletions(-)
diff --git
a/pulsar-client-reactive-adapter/src/main/java/org/apache/pulsar/reactive/client/internal/adapter/AdaptedReactiveMessageConsumerBuilder.java
b/pulsar-client-reactive-adapter/src/main/java/org/apache/pulsar/reactive/client/internal/adapter/AdaptedReactiveMessageConsumerBuilder.java
index b69381b..ed59a3c 100644
---
a/pulsar-client-reactive-adapter/src/main/java/org/apache/pulsar/reactive/client/internal/adapter/AdaptedReactiveMessageConsumerBuilder.java
+++
b/pulsar-client-reactive-adapter/src/main/java/org/apache/pulsar/reactive/client/internal/adapter/AdaptedReactiveMessageConsumerBuilder.java
@@ -17,11 +17,9 @@
package org.apache.pulsar.reactive.client.internal.adapter;
import org.apache.pulsar.client.api.Schema;
-import
org.apache.pulsar.reactive.client.api.ImmutableReactiveMessageConsumerSpec;
import
org.apache.pulsar.reactive.client.api.MutableReactiveMessageConsumerSpec;
import org.apache.pulsar.reactive.client.api.ReactiveMessageConsumer;
import org.apache.pulsar.reactive.client.api.ReactiveMessageConsumerBuilder;
-import org.apache.pulsar.reactive.client.api.ReactiveMessageConsumerSpec;
class AdaptedReactiveMessageConsumerBuilder<T> implements
ReactiveMessageConsumerBuilder<T> {
@@ -37,11 +35,6 @@ class AdaptedReactiveMessageConsumerBuilder<T> implements
ReactiveMessageConsume
this.reactiveConsumerAdapterFactory =
reactiveConsumerAdapterFactory;
}
- @Override
- public ReactiveMessageConsumerSpec toImmutableSpec() {
- return new
ImmutableReactiveMessageConsumerSpec(this.consumerSpec);
- }
-
@Override
public MutableReactiveMessageConsumerSpec getMutableSpec() {
return this.consumerSpec;
diff --git
a/pulsar-client-reactive-adapter/src/main/java/org/apache/pulsar/reactive/client/internal/adapter/AdaptedReactiveMessageReaderBuilder.java
b/pulsar-client-reactive-adapter/src/main/java/org/apache/pulsar/reactive/client/internal/adapter/AdaptedReactiveMessageReaderBuilder.java
index 03888e9..252caae 100644
---
a/pulsar-client-reactive-adapter/src/main/java/org/apache/pulsar/reactive/client/internal/adapter/AdaptedReactiveMessageReaderBuilder.java
+++
b/pulsar-client-reactive-adapter/src/main/java/org/apache/pulsar/reactive/client/internal/adapter/AdaptedReactiveMessageReaderBuilder.java
@@ -18,11 +18,9 @@ package org.apache.pulsar.reactive.client.internal.adapter;
import org.apache.pulsar.client.api.Schema;
import org.apache.pulsar.reactive.client.api.EndOfStreamAction;
-import
org.apache.pulsar.reactive.client.api.ImmutableReactiveMessageReaderSpec;
import org.apache.pulsar.reactive.client.api.MutableReactiveMessageReaderSpec;
import org.apache.pulsar.reactive.client.api.ReactiveMessageReader;
import org.apache.pulsar.reactive.client.api.ReactiveMessageReaderBuilder;
-import org.apache.pulsar.reactive.client.api.ReactiveMessageReaderSpec;
import org.apache.pulsar.reactive.client.api.StartAtSpec;
class AdaptedReactiveMessageReaderBuilder<T> implements
ReactiveMessageReaderBuilder<T> {
@@ -54,11 +52,6 @@ class AdaptedReactiveMessageReaderBuilder<T> implements
ReactiveMessageReaderBui
return this;
}
- @Override
- public ReactiveMessageReaderSpec toImmutableSpec() {
- return new ImmutableReactiveMessageReaderSpec(this.readerSpec);
- }
-
@Override
public MutableReactiveMessageReaderSpec getMutableSpec() {
return this.readerSpec;
diff --git
a/pulsar-client-reactive-adapter/src/main/java/org/apache/pulsar/reactive/client/internal/adapter/AdaptedReactiveMessageSenderBuilder.java
b/pulsar-client-reactive-adapter/src/main/java/org/apache/pulsar/reactive/client/internal/adapter/AdaptedReactiveMessageSenderBuilder.java
index 846ce4f..c060cae 100644
---
a/pulsar-client-reactive-adapter/src/main/java/org/apache/pulsar/reactive/client/internal/adapter/AdaptedReactiveMessageSenderBuilder.java
+++
b/pulsar-client-reactive-adapter/src/main/java/org/apache/pulsar/reactive/client/internal/adapter/AdaptedReactiveMessageSenderBuilder.java
@@ -19,12 +19,10 @@ package org.apache.pulsar.reactive.client.internal.adapter;
import java.util.function.Supplier;
import org.apache.pulsar.client.api.Schema;
-import
org.apache.pulsar.reactive.client.api.ImmutableReactiveMessageSenderSpec;
import org.apache.pulsar.reactive.client.api.MutableReactiveMessageSenderSpec;
import org.apache.pulsar.reactive.client.api.ReactiveMessageSender;
import org.apache.pulsar.reactive.client.api.ReactiveMessageSenderBuilder;
import org.apache.pulsar.reactive.client.api.ReactiveMessageSenderCache;
-import org.apache.pulsar.reactive.client.api.ReactiveMessageSenderSpec;
import org.apache.pulsar.reactive.client.internal.api.InflightLimiter;
import org.apache.pulsar.reactive.client.internal.api.PublisherTransformer;
import reactor.core.scheduler.Schedulers;
@@ -61,11 +59,6 @@ class AdaptedReactiveMessageSenderBuilder<T> implements
ReactiveMessageSenderBui
return this;
}
- @Override
- public ReactiveMessageSenderSpec toImmutableSpec() {
- return new ImmutableReactiveMessageSenderSpec(this.senderSpec);
- }
-
@Override
public MutableReactiveMessageSenderSpec getMutableSpec() {
return this.senderSpec;
diff --git
a/pulsar-client-reactive-api/src/main/java/org/apache/pulsar/reactive/client/api/ReactiveMessageConsumerBuilder.java
b/pulsar-client-reactive-api/src/main/java/org/apache/pulsar/reactive/client/api/ReactiveMessageConsumerBuilder.java
index b86d5f9..aa13a57 100644
---
a/pulsar-client-reactive-api/src/main/java/org/apache/pulsar/reactive/client/api/ReactiveMessageConsumerBuilder.java
+++
b/pulsar-client-reactive-api/src/main/java/org/apache/pulsar/reactive/client/api/ReactiveMessageConsumerBuilder.java
@@ -58,7 +58,9 @@ public interface ReactiveMessageConsumerBuilder<T> {
* Converts this builder to an immutable reactive consumer spec.
* @return the reactive consumer spec.
*/
- ReactiveMessageConsumerSpec toImmutableSpec();
+ default ReactiveMessageConsumerSpec toImmutableSpec() {
+ return new
ImmutableReactiveMessageConsumerSpec(getMutableSpec());
+ }
/**
* Converts this builder to a mutable reactive consumer spec.
diff --git
a/pulsar-client-reactive-api/src/main/java/org/apache/pulsar/reactive/client/api/ReactiveMessageReaderBuilder.java
b/pulsar-client-reactive-api/src/main/java/org/apache/pulsar/reactive/client/api/ReactiveMessageReaderBuilder.java
index 85f924f..beb02f5 100644
---
a/pulsar-client-reactive-api/src/main/java/org/apache/pulsar/reactive/client/api/ReactiveMessageReaderBuilder.java
+++
b/pulsar-client-reactive-api/src/main/java/org/apache/pulsar/reactive/client/api/ReactiveMessageReaderBuilder.java
@@ -71,7 +71,9 @@ public interface ReactiveMessageReaderBuilder<T> {
* Gets an immutable spec from the underlying spec of this builder.
* @return the immutable reactive reader spec.
*/
- ReactiveMessageReaderSpec toImmutableSpec();
+ default ReactiveMessageReaderSpec toImmutableSpec() {
+ return new ImmutableReactiveMessageReaderSpec(getMutableSpec());
+ }
/**
* Gets the mutable spec of this builder.
diff --git
a/pulsar-client-reactive-api/src/main/java/org/apache/pulsar/reactive/client/api/ReactiveMessageSenderBuilder.java
b/pulsar-client-reactive-api/src/main/java/org/apache/pulsar/reactive/client/api/ReactiveMessageSenderBuilder.java
index c690c68..6f2ac5a 100644
---
a/pulsar-client-reactive-api/src/main/java/org/apache/pulsar/reactive/client/api/ReactiveMessageSenderBuilder.java
+++
b/pulsar-client-reactive-api/src/main/java/org/apache/pulsar/reactive/client/api/ReactiveMessageSenderBuilder.java
@@ -81,7 +81,9 @@ public interface ReactiveMessageSenderBuilder<T> {
* Converts this builder to an immutable reactive sender spec with the
same settings.
* @return the reactive sender spec.
*/
- ReactiveMessageSenderSpec toImmutableSpec();
+ default ReactiveMessageSenderSpec toImmutableSpec() {
+ return new ImmutableReactiveMessageSenderSpec(getMutableSpec());
+ }
/**
* Converts this builder to a mutable reactive sender spec with the
same settings.
