codelipenghui commented on code in PR #18633:
URL: https://github.com/apache/pulsar/pull/18633#discussion_r1034201729
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TopicsConsumerImplTest.java:
##########
@@ -539,6 +540,38 @@ public void testTopicNameValid() throws Exception{
}).get();
}
+ @Test
+ public void testExclusiveSubscribe() throws Exception {
+ final String topicName =
"persistent://prop/use/ns-abc/testTopicNameValid";
+ TenantInfoImpl tenantInfo = createDefaultTenantInfo();
+ admin.tenants().createTenant("prop", tenantInfo);
+ admin.topics().createPartitionedTopic(topicName, 3);
+ List<Integer> partitions = new ArrayList<>();
+ for (int i = 0; i < 3; i++) {
+ partitions.add(i);
+ }
+ List<String> realTopics = partitions.stream()
+ .map(idx -> topicName + "-partition-" + idx)
+ .collect(Collectors.toList());
+ Consumer<byte[]> consumer1 = pulsarClient.newConsumer()
+ .topics(realTopics)
+ .subscriptionName("subscriptionName")
+ .subscriptionType(SubscriptionType.Exclusive)
+ .subscribeAsync().get(10, TimeUnit.SECONDS);
+
+
+ try {
+ Consumer<byte[]> consumer2 = pulsarClient.newConsumer()
+ .topics(realTopics)
+ .subscriptionName("subscriptionName")
+ .subscriptionType(SubscriptionType.Exclusive)
+ .subscribeAsync().get(10, TimeUnit.SECONDS);
+ } catch (Exception e) {
+ String errorLog = e.getMessage();
+ assertTrue(errorLog != null && errorLog.contains("Exclusive
consumer is already connected"));
Review Comment:
If no exception is thrown, the test can still get passed.
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TopicsConsumerImplTest.java:
##########
@@ -539,6 +540,38 @@ public void testTopicNameValid() throws Exception{
}).get();
}
+ @Test
+ public void testExclusiveSubscribe() throws Exception {
+ final String topicName =
"persistent://prop/use/ns-abc/testTopicNameValid";
+ TenantInfoImpl tenantInfo = createDefaultTenantInfo();
+ admin.tenants().createTenant("prop", tenantInfo);
+ admin.topics().createPartitionedTopic(topicName, 3);
+ List<Integer> partitions = new ArrayList<>();
+ for (int i = 0; i < 3; i++) {
+ partitions.add(i);
+ }
+ List<String> realTopics = partitions.stream()
+ .map(idx -> topicName + "-partition-" + idx)
+ .collect(Collectors.toList());
+ Consumer<byte[]> consumer1 = pulsarClient.newConsumer()
+ .topics(realTopics)
+ .subscriptionName("subscriptionName")
+ .subscriptionType(SubscriptionType.Exclusive)
+ .subscribeAsync().get(10, TimeUnit.SECONDS);
Review Comment:
```suggestion
.subscribe();
```
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TopicsConsumerImplTest.java:
##########
@@ -539,6 +540,38 @@ public void testTopicNameValid() throws Exception{
}).get();
}
+ @Test
+ public void testExclusiveSubscribe() throws Exception {
+ final String topicName =
"persistent://prop/use/ns-abc/testTopicNameValid";
Review Comment:
It's better not to use the V1 version topic name. We will remove it in the
future.
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TopicsConsumerImplTest.java:
##########
@@ -539,6 +540,38 @@ public void testTopicNameValid() throws Exception{
}).get();
}
+ @Test
+ public void testExclusiveSubscribe() throws Exception {
+ final String topicName =
"persistent://prop/use/ns-abc/testTopicNameValid";
+ TenantInfoImpl tenantInfo = createDefaultTenantInfo();
+ admin.tenants().createTenant("prop", tenantInfo);
+ admin.topics().createPartitionedTopic(topicName, 3);
+ List<Integer> partitions = new ArrayList<>();
+ for (int i = 0; i < 3; i++) {
+ partitions.add(i);
+ }
+ List<String> realTopics = partitions.stream()
+ .map(idx -> topicName + "-partition-" + idx)
+ .collect(Collectors.toList());
+ Consumer<byte[]> consumer1 = pulsarClient.newConsumer()
+ .topics(realTopics)
Review Comment:
Why not subscribe to the partitioned topic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
