rdhabalia commented on PR #18663: URL: https://github.com/apache/pulsar/pull/18663#issuecomment-1331556887
@codelipenghui I don't think this will require PIP as it's part of adding a flag in admin API. There are a large number of PRs which must have gone through PIP with similar changes but merge without any explanation. let me give you few examples https://github.com/apache/pulsar/pull/16167 https://github.com/apache/pulsar/pull/14680 https://github.com/apache/pulsar/pull/12136 https://github.com/apache/pulsar/pull/13938 also PR which breaks backward compatibility https://github.com/apache/pulsar/pull/10601 was merged without any concerns. I have many such examples where I see practice by the specific community to discourage people from their contribution and delay their efforts. I would strongly discourage such destructive practices. There are such bad practices going on in the community and I have many examples. Please let us know if you have any concerns with the PR by adding an option flag if not then you should not BLOCK the PR unnecessarily as it will start -ve and destructive practice in the community and we didn't open source Pulsar for such things. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
