momo-jun commented on PR #18675:
URL: https://github.com/apache/pulsar/pull/18675#issuecomment-1331735168

   > > @315157973 thanks for adding the docs! Since it works on top of 
`ThresholdShedder`, does it make sense to move this newly added content a bit 
later ([starting from 
Row168](https://github.com/apache/pulsar/pull/18675/files#diff-28f860baebb586ef32c135e35e748de9be77675fe575018ce2e18d7f9405d660R168)),
 following the complete content of `ThresholdShedder`?
   > 
   > This part explain the load balancing strategy. If we divide them into two 
parts, the meaning will be incoherent
   
   Also make sense. My thought - it breaks the coherent content of 
`ThresholdShedder` and also has a dependency on the configuration of 
`ThresholdShedder`, so it looks a bit advancing if we introduce it ahead of 
`ThresholdShedder`. It's not a broker anyway :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to