BewareMyPower commented on code in PR #128:
URL: https://github.com/apache/pulsar-client-cpp/pull/128#discussion_r1035653396
##########
tests/BasicEndToEndTest.cc:
##########
@@ -4277,7 +4277,9 @@ TEST(BasicEndToEndTest, testBatchReceiveClose) {
testBatchReceiveClose(false); }
TEST(BasicEndToEndTest, testBatchReceiveCloseWithMultiConsumer) {
testBatchReceiveClose(true); }
-TEST(BasicEndToEndTest, testAckMsgList) {
+class AcknowledgeTest : public testing::TestWithParam<int> {};
Review Comment:
It make sense to me.
BTW, the `BasicEndToEndTest` is too huge, adding a test into this file
requires much more compile time than others. The original purpose is to use
another PR to split tests in this file. For this PR, I will split the test
class to another file soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
