lhotari commented on PR #18668: URL: https://github.com/apache/pulsar/pull/18668#issuecomment-1332073458
@nicoloboschi @eolivelli I'm just wondering if the behavior of `conditionalIdHashing` should be revisited slightly. In most cases, the id will be the clear text one. However when the length goes over 512 bytes, it becomes a hash value. The length of the resulting base64 encoded value is fairly short. For example in the test, the `AkJcD1sNq/PSuRFfP3cjoCrYvPsVNKDSMWFP1CuBiPY` is an example and the length is 43 bytes. Why not take a prefix (512-43 bytes=469 bytes) from the original value and add the hash to the end to make it a unique 512 bytes value? This probably doesn't matter that much, but it could make the id values more human readable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
