mgrenonville opened a new pull request, #13298: URL: https://github.com/apache/pulsar/pull/13298
Fixes https://github.com/apache/pulsar/issues/11646 ### Motivation When using `loadConf`, ConfigurationDataUtils was loading existing values in a Map using Jackson mapper. If there is a `@JsonIgnore`, Jackson ignores theses fields, but there will be forgotten in the new instance. ### Modifications Using `readerForUpdating(existingData).readValue(configJson)` will refresh only overriden values in config map. ### Verifying this change - [x] Make sure that the change passes the CI checks. This change is already covered by existing tests, such as *org.apache.pulsar.client.impl.conf.ConfigurationDataUtilsTest*. ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): no - The public API: no - The schema: no - The default values of configurations: no - The wire protocol: no - The rest endpoints: no - The admin cli options: no - Anything that affects deployment: no (at least, it will no longer fails silently on `@JsonIgnore` properties) ### Documentation Check the box below and label this PR (if you have committer privilege). Need to update docs? - [x] `no-need-doc` This was a bug in `loadConf` code, it is intended to work as follow (I think) - [x] `doc-not-needed` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
