BewareMyPower commented on code in PR #18729:
URL: https://github.com/apache/pulsar/pull/18729#discussion_r1040982506
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractBaseDispatcher.java:
##########
@@ -93,22 +93,25 @@ protected AbstractBaseDispatcher(Subscription subscription,
ServiceConfiguration
public int filterEntriesForConsumer(List<? extends Entry> entries,
EntryBatchSizes batchSizes,
SendMessageInfo sendMessageInfo, EntryBatchIndexesAcks indexesAcks,
ManagedCursor cursor, boolean isReplayRead, Consumer consumer) {
- return filterEntriesForConsumer(Optional.empty(), 0, entries,
batchSizes, sendMessageInfo, indexesAcks, cursor,
+ return filterEntriesForConsumer(null, 0, entries, batchSizes,
Review Comment:
`null` is good enough to represent an "empty" value. Especially we have
`@Nullable` annotation here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
