Jason918 commented on code in PR #18801:
URL: https://github.com/apache/pulsar/pull/18801#discussion_r1042884940
##########
conf/standalone.conf:
##########
@@ -29,6 +29,8 @@ metadataStoreUrl=
# Configuration file path for metadata store. It's supported by
RocksdbMetadataStore and EtcdMetadataStore for now
metadataStoreConfigPath=
+# Whether we should enable fsync for local metadata store. It's supported by
RocksdbMetadataStore for now
Review Comment:
It would be more clear to add this: "If this flag is true, metadata writes
will be slower. If this flag is false, and the machine crashes, some recent
metadata writes may be lost. Note that if it is just the process that crashes
(i.e., the machine does not reboot), no writes will be lost even if it is
false."
##########
pulsar-metadata/src/test/java/org/apache/pulsar/metadata/MetadataBenchmark.java:
##########
@@ -108,7 +108,8 @@ public void testGetChildren(String provider,
Supplier<String> urlSupplier) throw
@Test(dataProvider = "impl", enabled = false)
public void testPut(String provider, Supplier<String> urlSupplier) throws
Exception {
@Cleanup
- MetadataStore store = MetadataStoreFactory.create(urlSupplier.get(),
MetadataStoreConfig.builder().build());
+ MetadataStore store = MetadataStoreFactory.create(urlSupplier.get(),
Review Comment:
NIT: This benchmark is not even a unit test. It's more like a perf tool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
