yuruguo opened a new pull request, #18814: URL: https://github.com/apache/pulsar/pull/18814
### Motivation Change the data type of the `allowAutoTopicCreationType` from `String` to `TopicType` enum in Configuration, which could supplement the verification for its value when creating the configuration, so that the broker will stop directly if the value is invalid. Before this, if the value of `allowAutoTopicCreationType` is illegal but lacks verification, the broker can still start normally but may encounter unexpected results when using this value. For example, if the user sets `allowAutoTopicCreation` to `ture` b and wants to create the topic automatically as partitioned topic(`allowAutoTopicCreationType = partitioned`) in broker.conf, but mistakenly sets `allowAutoTopicCreationType` to `partition`, the broker can start normally but it is a partition topic when automatically creating the topic. ### Modifications - Change type of allowAutoTopicCreationType from `String` to `TopicType` ### Verifying this change - [x] Make sure that the change passes the CI checks. ### Documentation - [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [x] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> ### Matching PR in forked repository PR in forked repository: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
