MarvinCai commented on a change in pull request #4265:
[transaction][acknowledge] Introduce PENDING_ACK state in acknowledgement path
URL: https://github.com/apache/pulsar/pull/4265#discussion_r286776994
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java
##########
@@ -185,8 +224,15 @@ public void consumerFlow(Consumer consumer, int
additionalNumberOfMessages) {
@Override
public void acknowledgeMessage(List<Position> positions, AckType ackType,
Map<String,Long> properties) {
if (ackType == AckType.Cumulative) {
+ if (this.txnID != null) {
+ log.warn("[{}][{}] An ongoing transaction:{}{} is doing
cumulative ack, " +
+ "new cumulative ack is not allowed till the
transaction is committed.",
+ this.txnID.getMostSigBits(),
this.txnID.getLeastSigBits(), topicName, subName);
Review comment:
updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
