RobertIndie commented on code in PR #14287:
URL: https://github.com/apache/pulsar/pull/14287#discussion_r1045609383
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java:
##########
@@ -1026,8 +1028,9 @@ public CompletableFuture<Void> closeAsync() {
closeConsumerTasks();
deregisterFromClientCnx();
client.cleanupConsumer(this);
- failPendingReceive().whenComplete((r, t) ->
closeFuture.complete(null));
- return closeFuture;
+ failPendingReceive().whenComplete((r, t) ->
closeConsumerFuture.complete(null));
+ closeFutures.addAll(closeDeadAndRetryProducer());
Review Comment:
Is there a case that the consumer is disconnected, but the DLQ and retry
producer are not closed? I think we may need to handle that case as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
