poorbarcode commented on code in PR #18928:
URL: https://github.com/apache/pulsar/pull/18928#discussion_r1049193185
##########
pulsar-broker/src/main/java/org/apache/pulsar/client/impl/RawReaderImpl.java:
##########
@@ -203,12 +232,17 @@ public CompletableFuture<Void> seekAsync(MessageId
messageId) {
@Override
public CompletableFuture<Void> closeAsync() {
+ CompletableFuture<Void> closeFuture = super.closeAsync();
reset();
- return super.closeAsync();
+ return closeFuture;
}
@Override
void messageReceived(CommandMessage commandMessage, ByteBuf
headersAndPayload, ClientCnx cnx) {
+ State state = getState();
+ if (state == State.Closing || state == State.Closed) {
+ return;
Review Comment:
Should we release `headersAndPayload ` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
