shibd commented on PR #142: URL: https://github.com/apache/pulsar-client-cpp/pull/142#issuecomment-1354392259
> It looks like this PR mainly solves the issue that the producer cannot be created when isSchemaValidationEnforced is true. But the validation still requires the new dependencies like Avro. Otherwise, the AUTO_PUBLISH schema with no validation could be weird. Yes, and we also need to support setting the schema when sending messages. Only then is `AUTO_PUBLISH` fully usable. > We should not introduce the validation logic into the C++ client. Maybe we can think of a way to support passing a customized message builder so that we can perform the validation on a generic type without exposing the internal code. I think we can open an issue or mail thread to discuss it. > Could you describe in which case could the DLQ topic have schema? I thought he topic could only be created by the client itself, right? Yes, When the user creates a dead-letter topic by himself, and the schema of the dead-letter topic is not compatible from the schema of the source topic, the DLQ producer will create failed. BTW: This scenario is relatively rare, and I don't think it affects the release of DLQ features. I will close this PR first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
