congbobo184 commented on code in PR #18971:
URL: https://github.com/apache/pulsar/pull/18971#discussion_r1051548349
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java:
##########
@@ -632,6 +641,14 @@ public void run() {
callBack.noNeedToRecover();
return;
}
+ } catch (TimeoutException ex) {
+ Throwable t =
FutureUtil.unwrapCompletionException(ex);
+ String errorMessage = String.format("[%s]
Transaction buffer recover fail by read "
+ + "transactionBufferSnapshot
timeout!", topic.getName());
+ log.error(errorMessage, t);
+ callBack.recoverExceptionally(
+ new
BrokerServiceException.ServiceUnitNotReadyException(errorMessage, t));
Review Comment:
should close the reader, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
