izumo27 commented on PR #126: URL: https://github.com/apache/pulsar-client-cpp/pull/126#issuecomment-1357855166
> After I reverted your changes in ClientConnection.cc, these tests could still pass. ```testTlsDetectPulsarSslWithHostNameValidationMissingCertsFile``` tests whether the result of ```createProducer``` is a connection error when certsFile is missing. Hostname verification of master always fails, so this test could still pass. This PR fixes ```testTlsDetectPulsarSslWithHostNameValidation```. When certsFile is set corretly, the result of ```createProducer``` should be ok. https://github.com/apache/pulsar-client-cpp/blob/v3.1.0/tests/AuthPluginTest.cc#L152 https://github.com/apache/pulsar-client-cpp/pull/126/files#diff-43a1460bfe2216170e3d7a5f634e8d0422b78946b018f81118dc275cbba2d04fR152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
