shibd commented on code in PR #139:
URL: https://github.com/apache/pulsar-client-cpp/pull/139#discussion_r1052850477
##########
lib/ConsumerImpl.cc:
##########
@@ -460,6 +476,7 @@ void ConsumerImpl::messageReceived(const
ClientConnectionPtr& cnx, const proto::
return;
}
+ auto redeliveryCount = msg.redelivery_count();
Review Comment:
It seems that this is another problem: we need to give the client that
cannot decrypt the message a chance to re-decrypt the message, so we need to
put it in `unAckedMessageTracker ` and wait for re-delivery.
https://github.com/apache/pulsar/pull/3097
As for why `redeliveryCount` is passed into `decryptPayloadIfNeeded` methods
in the Java implementation, it is because of the support for
[PIP-130](https://github.com/apache/pulsar/pull/13707)
Note: I'll open a new PR to support both issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
