RobertIndie commented on code in PR #148:
URL: https://github.com/apache/pulsar-client-cpp/pull/148#discussion_r1053099816
##########
include/pulsar/Message.h:
##########
@@ -188,8 +188,7 @@ class PULSAR_PUBLIC Message {
MessageImplPtr impl_;
Message(MessageImplPtr& impl);
- Message(const proto::CommandMessage& msg, proto::MessageMetadata& data,
SharedBuffer& payload,
- int32_t partition);
+ Message(const MessageId& messageId, proto::MessageMetadata& metadata,
SharedBuffer& payload);
Review Comment:
Agree. We should make the constructor clearer and make this existing
implementation out of the constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
