[GitHub] [pulsar] Technoboy- commented on a diff in pull request #19021: [fix][broker] Fix thread safety issue in info-internal admin api for partitioned topics

Wed, 21 Dec 2022 19:37:14 -0800 


Technoboy- commented on code in PR #19021:
URL: https://github.com/apache/pulsar/pull/19021#discussion_r1055056827


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -1330,10 +1322,15 @@ protected void 
internalGetManagedLedgerInfo(AsyncResponse asyncResponse, boolean
                                     asyncResponse.resume(new RestException(t));
                                 }
                             }
+                            PartitionedManagedLedgerInfo 
partitionedManagedLedgerInfo =

Review Comment:
   Do we need to add `else` block for line 1325 ~1333 ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to