BewareMyPower commented on PR #19031: URL: https://github.com/apache/pulsar/pull/19031#issuecomment-1362999460
More explanations to the refactoring parts of this PR: 1. I don't want to handle the list cumulative acknowledgment. Pulsar never supports this operation. There is no `acknowledgeCumulative` API that accepts a list of messages. 2. Process the `BatchMessageIdImpl` in `ConsumerImpl`. The previous code processes it mainly in `PersistentAcknowledgmentTracker`, it appearly does not follow the OOP style and there are a lot of `consumer.getXXX()` calls. I don't want to write more code based on that, e.g. using `consumer.getBatchMessageToAcker()` everywhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
