eolivelli commented on code in PR #18981:
URL: https://github.com/apache/pulsar/pull/18981#discussion_r1056808187
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/BatchMessageIdImpl.java:
##########
@@ -140,4 +151,16 @@ public BatchMessageAcker getAcker() {
return acker;
}
+ static int messageIdCompare(
+ long ledgerId1, long entryId1, int partitionIndex1, int
batchIndex1,
+ long ledgerId2, long entryId2, int partitionIndex2, int batchIndex2
+ ) {
+ return ComparisonChain.start()
+ .compare(ledgerId1, ledgerId2)
Review Comment:
This code will be exd uted in hot paths probably.
Is it better to use raw java code? We could save method calls and allocations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
