tpiperatgod commented on code in PR #18951:
URL: https://github.com/apache/pulsar/pull/18951#discussion_r1057042984
##########
pulsar-functions/instance/src/main/python/python_instance_main.py:
##########
@@ -88,8 +132,10 @@ def main():
parser.add_argument('--extra_dependency_repository', required=False,
help='For packaged python like wheel files, any extra repository to pull the
dependencies from')
parser.add_argument('--state_storage_serviceurl', required=False,
help='Managed State Storage Service Url')
parser.add_argument('--cluster_name', required=True, help='The name of the
cluster this instance is running on')
Review Comment:
you're right, I adjust all args to `required=False` and add a new function
`validate_arguments()` to verify the merged args, mainly to check the mandatory
args.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
