yuruguo commented on PR #19048:
URL: https://github.com/apache/pulsar/pull/19048#issuecomment-1365080844
> @yuruguo Thanks for your contributions. This is a breaking change for
PulsarClient API, so could you please make a discussion in the mail list?
@poorbarcode @liangyepianzhou Thanks for your reply.
> This changes the public API
This is a breaking change for PulsarClient API
It is recommended to use the new method `newTableView(Schema)` to replace
the deprecated method `newTableViewBuilder(Schema)` although it can still be
used in later release version, and both ultimately call the same method `new
TableViewBuilderImpl<>(this, schema)`, so I understand this will not break.
```
@Override
@Deprecated
public <T> TableViewBuilder<T> newTableViewBuilder(Schema<T> schema) {
return new TableViewBuilderImpl<>(this, schema);
}
@Override
public <T> TableViewBuilder<T> newTableView(Schema<T> schema) {
return new TableViewBuilderImpl<>(this, schema);
}
```
> so could you please make a discussion in the mail list?
That's no problem and I can start a discussion at Pulsar Dev Mail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]