RobertIndie commented on code in PR #156:
URL: https://github.com/apache/pulsar-client-cpp/pull/156#discussion_r1058133945


##########
lib/ClientConnection.cc:
##########
@@ -1596,7 +1596,11 @@ void ClientConnection::close(Result result) {
     }
 
     lock.unlock();
-    LOG_INFO(cnxString_ << "Connection closed with " << result);
+    if (result != ResultDisconnected) {
+        LOG_ERROR(cnxString_ << "Connection closed with " << result);

Review Comment:
   It will pass the default result value `ResultConnectError` to the `close()` 
to indicate that the connection is closed unexpectedly. 
   In addition, the info log with the `ConnectError` message seems confusing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to