sijie commented on a change in pull request #4367: [document][swagger]Update
topics rest api document
URL: https://github.com/apache/pulsar/pull/4367#discussion_r287554762
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java
##########
@@ -68,7 +69,11 @@
@ApiOperation(value = "Get the list of topics under a namespace.",
response = String.class, responseContainer = "List")
@ApiResponses(value = { @ApiResponse(code = 403, message = "Don't have
admin permission"),
@ApiResponse(code = 404, message = "Namespace doesn't exist") })
- public List<String> getList(@PathParam("tenant") String tenant,
@PathParam("namespace") String namespace) {
+ public List<String> getList(
+ @ApiParam(value = "Specify the tenant to which this topic
belongs", required = true)
+ @PathParam("tenant") String tenant,
+ @ApiParam(value = "Specify the namespace to which this topic
belongs", required = true)
Review comment:
the comment " which this topic belongs" is wrong here. the action is to
fetch the list of topics for a given namespace, we don't know any topic yet, no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
