nicoloboschi commented on code in PR #19118:
URL: https://github.com/apache/pulsar/pull/19118#discussion_r1060009378
##########
pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/BacklogQuota.java:
##########
@@ -42,7 +42,7 @@ public interface BacklogQuota {
*
* @return quota limit in bytes
*/
- long getLimitSize();
+ long getLimitSizeInBytes();
Review Comment:
Also for completeness we should change the builder method
https://github.com/apache/pulsar/pull/19118/files#diff-6818b3dc13db4b7fd2504c6638af715ccf140d0c6d4c17a80420c80052889fd3L57
##########
pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/BacklogQuota.java:
##########
@@ -42,7 +42,7 @@ public interface BacklogQuota {
*
* @return quota limit in bytes
*/
- long getLimitSize();
+ long getLimitSizeInBytes();
Review Comment:
This will break existing admin java clients.
Do we have a strong reason to change it ? If so, we should mark this as
deprecated and add a new method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
