BewareMyPower commented on code in PR #17449:
URL: https://github.com/apache/pulsar/pull/17449#discussion_r1061639462


##########
pulsar-common/src/main/proto/PulsarApi.proto:
##########
@@ -51,6 +51,7 @@ message Schema {
     required bytes schema_data = 3;
     required Type type = 4;
     repeated KeyValue properties = 5;
+    optional bool is_auto_consume_schema = 6 [default = false];

Review Comment:
   I think it's better to add the field to `CommandSubscribe` instead of the 
`Schema` itself.
   
   BTW, please modify your PIP first before pushing the commits.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to