lhotari commented on PR #19133:
URL: https://github.com/apache/pulsar/pull/19133#issuecomment-1371884102

   > @lhotari Thanks for your contribution!
   > 
   > It should be good to try. I have some questions here:
   > 
   > 1. How do you imagine we make use of the scan report?
   
   there are many ways to make use of the scan reports. For example, the test 
execution reports are useful for analysing flaky tests and slow tests. Here's 
an example of test execution reports:
   
https://ge.apache.org/scans/tests?search.rootProjectNames=Pulsar&search.timeZoneId=Europe/Helsinki&tests.container=*
   It seems that @poorbarcode has been working on improvements for slow tests 
in #17657 and child issues. Gradle Enterprise test reporting is a good way to 
find the slow tests.
   
   For other parts of the build, the build scan contains detailed break downs 
of where time is spent in the build. It's simply a way to get a better 
understanding of what happens during the build. One of the challenges is that 
Gradle Enterprise doesn't seem to provide a nice way to group the related 
builds in list views. There are links in the build scan report header to find 
other builds in the same workflow run or for the same git commit hash.
   
![image](https://user-images.githubusercontent.com/66864/210727434-3aa8808d-bed2-45ec-a217-950a1fdecfe3.png)
   However this isn't very helpful in the list views since there's no 
information there to see what build it actually is. That's why I added the 
links to the reports to the GitHub Actions workflow run [summary 
view](https://github.com/apache/pulsar/actions/runs/3839199234/attempts/1#summary-10438505199):
 
   
![image](https://user-images.githubusercontent.com/66864/210727721-7490b55b-3fd7-46fa-af2d-16614dbc558c.png)
    
   > 2. How much time does the new step consume?
   
   The Gradle Enterprise maven extension collects the information and logs and 
sends them when the build finishes. It doesn't seem to add more than a few 
seconds to execution. One detail is that this solution is only enabled for 
builds that happen on the apache/pulsar branches. The reason for this is that 
Gradle Enterprise has a secret token that is used for publishing to 
ge.apache.org . If we'd like to publish reports for pull requests, the token 
would have to be made public. I don't think that there are plans for doing that 
at the moment. 
   
   > 3. Is it possible to replace codecov with this scan so we reduce too many 
reports?
   
   This isn't a replacement for codecov. Currently codecov integration in 
apache/pulsar seems to be invalid and the results don't make sense. I think we 
should disable codecov reporting until it is fixed and it provides consistent 
results.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to